This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
add a null page view when all windows lose focus #3630
Merged
+57
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
force-pushed
the
window-blur
branch
4 times, most recently
from
f5aced5
to
b11e3d8
Compare
|
Could you link up the issue? Thanks. |
| break | ||
| case AppConstants.APP_IDLE_STATE_CHANGED: | ||
| if (action.idleState !== 'active') { | ||
| addPageView(null) |
There was a problem hiding this comment.
How does a null page view behave?
There was a problem hiding this comment.
it just logs the timestamp when the browser became inactive. We use the same thing for closing all windows
bridiver
force-pushed
the
window-blur
branch
from
b11e3d8
to
92722fb
Compare
add a null page view when idle fixes #3650
|
need to fix the commit, it should say fixes #3650 |
|
Moving to 0.12.1 for now, please merge when reviewed @mrose17 it could make it in a respin still. |
|
@bbondy - i have reviewed this PR and it works well on my system. @bridiver - we may need to iterate a bit in the future, specifically to deal with mouse enter events and scrolling events; however, i'd like us to drive this version for a while before digging into it again. many thanks for the fast updates! |
30 tasks
This was referenced Sep 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mrose17